<html>
<head><meta charset="utf-8"><title>Why &quot;r? @ghost&quot; · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html">Why &quot;r? @ghost&quot;</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="209492901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209492901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209492901">(Sep 09 2020 at 10:13)</a>:</h4>
<p>I was curious why on this rollup PR merge there's a mention to review from the github placeholder (used for closed accounts)<br>
<a href="https://github.com/rust-lang/rust/pull/76394">https://github.com/rust-lang/rust/pull/76394</a></p>
<p>I suspect because this tricks the system into moving the merge forward because a reviewer is needed but these PRs have already been approved</p>
<p>cc: <span class="user-mention" data-user-id="120823">@DPC</span></p>



<a name="209492984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209492984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209492984">(Sep 09 2020 at 10:14)</a>:</h4>
<p>Yeah since it's largely automated it doesn't need a reviewer</p>



<a name="209493048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209493048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> DPC <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209493048">(Sep 09 2020 at 10:15)</a>:</h4>
<p>A reviewer would increase latency of the rollup thus defeating the purpose of a rollup since some of those prs might get merged in the interim</p>



<a name="209493485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209493485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209493485">(Sep 09 2020 at 10:21)</a>:</h4>
<blockquote>
<p>I suspect because this tricks the system into moving the merge forward because a reviewer is needed</p>
</blockquote>
<p>As you have noticed rollup consists of already approved PRs and will get <code>r+</code> shortly after by the person who made it.<br>
Reviewer is not strictly necessary but <code>rust-highfive</code> bot assigns somebody to each new PR. So to avoid unnecessary pinging of the reviewers <code>@ghost</code> is assigned.</p>



<a name="209495007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209495007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> apiraino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209495007">(Sep 09 2020 at 10:40)</a>:</h4>
<p>thanks to both for the clarification :)</p>



<a name="209574785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Why%20%22r%3F%20%40ghost%22/near/209574785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Why.20.22r.3F.20.40ghost.22.html#209574785">(Sep 09 2020 at 22:09)</a>:</h4>
<p>Also see: <a href="#narrow/stream/122651-general/topic/what's.20.60r.3F.20.40ghost.60">https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/what's.20.60r.3F.20.40ghost.60</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>